Align behaviour for tests based on async generators with pytest #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arked with "asyncio" into a separate test module. The "test_simple" module is named too general. Thus, it serves as a magnet for all kinds of tests that aren't connected to each other. This is one step to break up the "test_simple" module into more coherent test modules. Signed-off-by: Michael Seifert <[email protected]>
…nstead of the older "testdir" fixture. Signed-off-by: Michael Seifert <[email protected]>
…xfail* status and emit a warning during the collection phase. This behavior is consistent with synchronous yield tests. Signed-off-by: Michael Seifert <[email protected]>
Tests use command-line arguments to set the asyncio mode and warnings filter, instead of a .ini file. This reduces the number of lines in the test module significantly. Signed-off-by: Michael Seifert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 93.28% 93.48% +0.20%
==========================================
Files 2 2
Lines 387 399 +12
Branches 83 85 +2
==========================================
+ Hits 361 373 +12
Misses 15 15
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test items based on asynchronous generators always exit with xfail status and emit a warning during the collection phase. This behavior is consistent with synchronous yield tests in pytest.
This changeset also fixes a regression introduced in main that caused these kind of tests to fail rather than skip or xfail.
Closes #642